Skip to content

loopback-explorer should pick up hideRemoteMethod called after the explorer was initialized #686

Closed

Description

@bajtos
// works, User.login is hidden
User.disableRemoteMethod('login', true);
app.use(explorer(app, { basePath: '/' }));

// does not work, User.login is shown in the UI
app.use(explorer(app, { basePath: '/' }));
User.disableRemoteMethod('login', true);

See also strongloop/loopback-component-explorer#22, #402 and #651

Activity

  1. supasate commented on Apr 27, 2016

    @supasate
    Contributor

    @bajtos Let me take this. (Anyway, I'm a beginner to this community. If I do something wrong, please advise.)

    I'll send one PR to this repo to make Loopback emits 'remoteMethodDisabled' event and one PR to loopback-component-explorer to re-create the swagger object when this event fired.

  2. bajtos commented on Apr 29, 2016

    @bajtos
    MemberAuthor

    I'll send one PR to this repo to make Loopback emits 'remoteMethodDisabled' event and one PR to loopback-component-explorer to re-create the swagger object when this event fired.

    Awesome, thank you for the contribution. I can see the first pull request was already landed :)

  3. bajtos commented on May 2, 2016

    @bajtos
    MemberAuthor

    Released in loopback@2.28.0 and loopback-component-explorer@2.5.0. Enjoy :)

  4. supasate commented on May 3, 2016

    @supasate
    Contributor

    @bajtos In loopback-component-explorer, should we change the loopback version in devDependency to be "^2.28.0" to make it more explicit about minimum requirement?

  5. bajtos commented on May 6, 2016

    @bajtos
    MemberAuthor

    In loopback-component-explorer, should we change the loopback version in devDependency to be "^2.28.0" to make it more explicit about minimum requirement?

    That's a good idea, could you please contribute that change yourself?

    I am closing this issue as resolved.

  6. supasate commented on May 6, 2016

    @supasate
    Contributor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions