Skip to content

Format CFBundleShortVersionString to spec - #176

Merged
stovmascript merged 1 commit into
stovmascript:masterfrom
wymsee:master
Mar 4, 2020
Merged

stovmascript merged 1 commit into
stovmascript:masterfrom
wymsee:master

Conversation

@DMcNamara

Copy link
Copy Markdown
Contributor

According to Apple:

The release version number is a string composed of three period-separated integers.

This change makes an attempt to pull out a string that is valid for CFBundleShortVersionString from the input, returning the input if no matches are found.

This is a potential fix for #41

According to Apple:
> The release version number is a string composed of three period-separated integers.

This change makes an attempt to pull out a string that is valid for CFBundleShortVersionString from the input, returning the input if no matches are found
@stovmascript

stovmascript commented Mar 3, 2020 •

Copy link
Copy Markdown
Owner

Hey @DMcNamara, thanks for the PR! Based on the tests, it looks like this change will make it return the previous version string when making/bumping a pre-release version. Will this cause problems when trying to release to TestFlight/App Store, or can that be handled by bumping the build number?

@DMcNamara

Copy link
Copy Markdown
Contributor Author

In our experience, putting anything in the CFBundleShortVersionString that is not int.int.int causes issues. We version things like 1.2.3-alpha.0, 1.2.3-alpha.1, etc. For all of those pre-release builds we upload to TestFlight with a CFBundleShortVersionString of 1.2.3 and increment the CFBundleVersion. Submitting it to the App Store also works as expected with just bumping the CFBundleVersion.

I'm not an Apple App Development expert by any means, so maybe I'm missing something but we've been using this process for a few months and it's been working.

@stovmascript
stovmascript merged commit f5577a2 into stovmascript:master Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants