Skip to content

Add support for ios MARKETING_VERSION build setting #186

Description

@archansel

Since XCode 11, CFBundleShortVersionString is managed using $(MARKETING_VERSION) from build setting, not a static value anymore

In react-native-version:4.0.0 it replace the value using static one

before
	<key>CFBundleShortVersionString</key>
	<string>$(MARKETING_VERSION)</string>
after
	<key>CFBundleShortVersionString</key>
	<string>0.1.0</string>

It will be better if it can handle build setting and change it accordingly in build setting file MyApp.xcodeproj > project.pbxproj both in debug and release

			buildSettings = {
				ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
				CURRENT_PROJECT_VERSION = 1;
				DEAD_CODE_STRIPPING = NO;
				INFOPLIST_FILE = BSQMobile/Info.plist;
				IPHONEOS_DEPLOYMENT_TARGET = 10.0;
				LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
				MARKETING_VERSION = 1.0.0; // CHANGE THIS INSTEAD
				OTHER_LDFLAGS = (
					"$(inherited)",
					"-ObjC",
					"-lc++",
				);
				PRODUCT_BUNDLE_IDENTIFIER = binus.itdivision.mobilebsq;
				PRODUCT_NAME = BSQMobile;
				VERSIONING_SYSTEM = "apple-generic";
			};

No activity

Activity on this issue will appear here.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions