Repository navigation
fix(sections): grey out Add when there is no room for a section - #820
Merged
Merged
Conversation
Add silently did nothing when the sections left no free space. It is now aria-disabled with a translated reason in its tooltip, kept in sync with sections, the loop, the song and the language. The Guide sentence says so. Closes #775
thcp
marked this pull request as ready for review
October 20, 2026 00:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #775
What changed
Disabled exactly when: no loop is armed AND no free gap fits a new section (static/js/sections.js refreshSectionsAddState).
Not changed: Add button kept, Sections label not renamed, Detect structure label untouched.
Test: karaoke 'each mode keeps its own saved mix' and 3 trash-restore specs fail on big-release too (pre-existing).