Repository navigation
Show an upload's format from the server, as a coloured file icon - #691
Merged
Merged
Conversation
An upload's source_url is "local:<title>", and the title has its extension removed, so the format icon from #678 read nothing and never appeared for a real file. It passed its tests against "local:e2e-fixture.wav", a shape no upload produces. The server now records source_format on upload and re-split, and fills it in for older uploads from the kept source.<ext>. The client takes it from job state, and backfills tracks already in the library at startup. The icon is a file with the format on a band, one colour per format. The quality label ("Lossless (WAV)") read the same missing suffix and now uses source_format too. A re-split's marker goes on the end of the source instead of before the last dot, which split titles like "Mr. Brightside". The e2e fixture now has the real shape and a kept source.wav. Closes #690
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #690
The format icon from #678 read an upload's format out of
source_url. For a real upload that islocal:<title>, and the title has its extension removed, so the icon never appeared. It passed its tests because the fixture usedlocal:e2e-fixture.wav, a shape no upload produces.What changes
source_formaton upload and on re-split, from the extension the file was validated against.source.<ext>the first time their state is served. Uploads finished before sources were kept have nothing to find and keep the note.source_format.Tests
local:e2e-fixture) and a keptsource.wav, so the backfill path runs end to end.format-icon.spec.mjsreplacesthumb-ext.spec.mjs: the row, the now-playing square, the startup backfill, a distinct colour per format, and which tracks get an icon.Checked against a local server with an existing library: uploads made before this change report
source_format: wavfrom their kept source.