Repository navigation
build(windows): don't bundle CUDA torch in the NVIDIA package (revert #318) - #320
Merged
Merged
Conversation
…318) #318 force-installed the CUDA torch wheel into the NVIDIA package, which pushed the release zip to 2456 MB -- over GitHub's 2 GiB release-asset cap (2147483648 bytes) -- so the Windows NVIDIA asset upload failed on the v0.8.0-alpha.12 release. Bundling was the wrong approach: the desktop app already installs the CUDA build on first run via ensure_torch_device (which picks the cuXXX index matching the detected GPU's compute capability / driver). The NVIDIA package is meant to ship base torch small (~419 MB zip) and pull CUDA on first launch. #317 is the actual fix -- it makes that first-run install trigger again after a CPU->NVIDIA build swap. Restore the non-CpuOnly path to base torch and document why not to bundle, so this isn't reintroduced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #318, which broke the Windows NVIDIA asset upload on the v0.8.0-alpha.12 release.
What happened
#318 force-installed the CUDA torch wheel into the NVIDIA package. That pushed
StemDeck-Windows-x64.NVIDIA.zipto 2456 MB, over GitHub's hard 2 GiB release-asset cap (2147483648 bytes):So the release got the macOS + Windows-CPU assets but not the Windows NVIDIA zip.
Why bundling was wrong
The desktop app already installs the CUDA build on first run via
ensure_torch_device(main.rs): it detects the GPU, picks thecuXXXindex matching the card's compute capability / driver, and pip-installs CUDA torch. The NVIDIA package is meant to ship base torch small (~419 MB zip) and pull CUDA on first launch — that's what the setup UI's "Installing NVIDIA acceleration… CUDA Torch packages are large" step is.Bundling CUDA torch (~2.5 GB installed) both blew the size cap and discarded the adaptive per-GPU CUDA-version selection. The genuine GPU-detection fix is #317 (re-probe after a CPU→NVIDIA build swap), which makes the first-run install trigger again — that's what actually fixed the reporter's machine.
Change
Restore the non-
CpuOnlypath to base torch (drop the CUDA force-install) and add a comment documenting why not to bundle, so this isn't reintroduced.Verified
Parser::ParseFile, no errors).Release recovery
The v0.8.0-alpha.12 tag has #318 baked in, so its Windows build will keep failing. After this merges, the release needs re-cutting (see follow-up note) — the Docker image and Unraid pin (#319) are unaffected.