Repository navigation
Add stellar token burn-from command - #2746
Merged
Merged
Conversation
fnando
added this pull request to stack #2745
September 22, 2026 17:10
fnando
force-pushed
the
token-burn-from
branch
from
September 22, 2026 17:12
5918f0a to
c7da1eb
Compare
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Preserve or explicitly reject muxed identity aliases to avoid targeting the wrong owner.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Adds the delegated SEP-41 stellar token burn-from command, allowing spenders to burn tokens from an owner's allowance.
Changes:
- Implements and registers
burn-from. - Adds JSON errors, documentation, and validation.
- Adds integration tests.
| File | Summary |
|---|---|
FULL_HELP_DOCS.md |
Documents the new command. |
cmd/soroban-cli/src/commands/token/mod.rs |
Registers the command and errors. |
cmd/soroban-cli/src/commands/token/burn_from.rs |
Implements delegated token burning. |
cmd/soroban-cli/src/cli.rs |
Adds JSON error-format support. |
cmd/crates/soroban-test/tests/it/integration/token/mod.rs |
Registers integration tests. |
cmd/crates/soroban-test/tests/it/integration/token/burn_from.rs |
Tests successful and invalid cases. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
fnando
force-pushed
the
token-burn-from
branch
from
September 22, 2026 23:21
c7da1eb to
c70b586
Compare
fnando
force-pushed
the
token-burn-from
branch
from
September 22, 2026 23:27
c70b586 to
8400519
Compare
fnando
force-pushed
the
token-burn-from
branch
from
September 23, 2026 00:10
8400519 to
cb59869
Compare
fnando
force-pushed
the
token-burn-from
branch
from
September 23, 2026 19:34
cb59869 to
b747451
Compare
leighmcculloch
approved these changes
Sep 23, 2026
leighmcculloch
left a comment
leighmcculloch
left a comment
Member
There was a problem hiding this comment.
There's a couple copilot comments that worth a look otherwise lgtm.
fnando
force-pushed
the
token-burn-from
branch
from
September 23, 2026 22:25
b747451 to
c4ab22b
Compare
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a
stellar token burn-fromcommand that lets a spender destroyamountof an owner's tokens by drawing on a granted allowance, implementing SEP-41'sburn_from(spender, from, amount). The spender is passed with--spender(which signs and authorizes), the owner with--from. Mirrors the existingtransfer-fromcommand minus the destination.Why
The CLI has
burn(self-signed) but no delegated variant. This addsburn-from, completing the burn pair the same waytransfer/transfer-fromare paired.Known limitations
M…) source accounts are rejected up front, since the invoke pipeline can't yet source from them (Support muxed (M…) source accounts in the contract invoke pipeline #2645).