Skip to content

Add stellar token symbol subcommand - #2712

Merged
fnando merged 2 commits into
mainfrom
token-symbol
Sep 8, 2026
Merged

fnando merged 2 commits into
mainfrom
token-symbol

Conversation

@fnando

@fnando fnando commented Sep 4, 2026

Copy link
Copy Markdown
Member

What

Adds stellar token symbol, a read-only subcommand returning a token's SEP-41 symbol() metadata. Resolves a token by --id (contract id, alias, native, or CODE:ISSUER) and prints the symbol as text or JSON.

Why

Part of #2620 (typed SEP-41 + SAC client), following name. Stacked on the token-name branch; a thin wrapper over contract invoke reusing args::invoke_by_position and args::not_deployed_error.

Known limitations

N/A

Copilot AI balanced review requested due to automatic review settings September 4, 2026 15:46
@github-project-automation github-project-automation Bot moved this to Backlog (Not Ready) in DevX Sep 4, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds stellar token symbol for querying SEP-41 symbol metadata.

Changes:

  • Adds read-only symbol invocation with text/JSON output.
  • Integrates command routing and structured errors.
  • Adds help documentation and integration tests.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
FULL_HELP_DOCS.md Documents the symbol command.
cmd/soroban-cli/src/commands/token/symbol.rs Implements symbol querying and output.
cmd/soroban-cli/src/commands/token/mod.rs Registers and dispatches the command.
cmd/soroban-cli/src/cli.rs Enables structured JSON errors.
cmd/crates/soroban-test/tests/it/integration/token/symbol.rs Tests SAC symbols and deployment errors.
cmd/crates/soroban-test/tests/it/integration/token/mod.rs Registers symbol integration tests.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread cmd/soroban-cli/src/commands/token/symbol.rs Outdated
Comment thread FULL_HELP_DOCS.md Outdated
Copilot AI review requested due to automatic review settings September 4, 2026 16:04

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

@fnando fnando self-assigned this Sep 4, 2026
@fnando fnando moved this from Backlog (Not Ready) to Needs Review in DevX Sep 4, 2026
Base automatically changed from token-name to main September 8, 2026 15:17
@fnando
fnando merged commit b71f1d3 into main Sep 8, 2026
344 of 349 checks passed
@fnando
fnando deleted the token-symbol branch September 8, 2026 16:05
@github-project-automation github-project-automation Bot moved this from Needs Review to Done in DevX Sep 8, 2026
@fnando fnando mentioned this pull request Oct 7, 2026
4 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants