Fix .image.json when TAG changes - #990
Open
leighmcculloch wants to merge 3 commits into
Open
leighmcculloch wants to merge 3 commits into
leighmcculloch wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Declare FORCE as phony to prevent stale .image.json output.
Review effort: Lite
Findings: None
What changed in this PR
Updates Makefile dependency tracking so .image.json regenerates when TAG changes.
Changes:
- Adds
.image.tagas a generated TAG marker. - Makes
.image.jsondepend on the marker. - Ignores
.image.tagin Git.
| File | Description |
|---|---|
Makefile |
Tracks TAG changes for image configuration regeneration. |
.gitignore |
Excludes the generated .image.tag file. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
mootz12
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Make
TAGan input to.image.jsonso it regenerates whenmakeruns with a different tag.Why
Running
make buildwith a differentTAGthan the previous build reused the stale.image.json, building the image with the previous tag's dependencies