Repository navigation
Feature request: make join() return self.__class__ to support subclassing #64
Description
Currently, the JsonPointer.join() method always returns a JsonPointer instance, even when called from a subclass:
class Pointer(jsonpointer.JsonPointer):
...
base = Pointer("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/some/object")
end = Pointer("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/actual/value")
full = base.join(end)
print(type(full))
# <class 'jsonpointer.JsonPointer'>If join() (and probably other methods) instead returned instances of self.__class__ instead of JsonPointer normal behavior would stay the same while allowing subclasses to work as expected.
E.g. with join() as:
def join(self, suffix):
""" Returns a new JsonPointer with the given suffix append to this ptr """
if isinstance(suffix, self.__class__):
suffix_parts = suffix.parts
elif isinstance(suffix, str):
suffix_parts = self.__class__(suffix).parts
else:
suffix_parts = suffix
try:
return self.__class__.from_parts(chain(self.parts, suffix_parts))
except: # noqa E722
raise JsonPointerException("Invalid suffix")You'd get:
print(type(JsonPointer("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/some/object") / JsonPointer("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/actual/value")))
# <class 'jsonpointer.JsonPointer'>
print(type(Pointer("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/some/object") / Pointer("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/actual/value")))
# <class '__main__.Pointer'>
Activity