Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23 and #32.
Adding an existing member increments
countwithout adding a distinct member; removing an absent member decrements it. Make both operations idempotent so replica requests use the actual member count.The replica search loops also fail to terminate when they start at index zero and cannot find enough distinct members. Bound traversal to one pass through the ring, returning only distinct members that are present. A regression uses two names with the same CRC32 replica hash to exercise this even when the membership count is correct.
Both regressions fail on the original code, including a two-second test timeout for the collision. Full
go test -vet=off -race -coverpasses (94.1% coverage). Vet is disabled because the pre-existingExampleAddandExampleRemovenames fail modern Go vet; the package predates modules and was tested under its canonical GOPATH import.