Repository navigation
docs(shell.core): LayoutStore is created by getAdapter too - #5
Merged
Merged
Conversation
The README said DockHost's getAdapter does not create LayoutStore, so the layout would silently never be saved. Adaptable.getAdapter constructs a class-token adapter on first use (requireAdapter only adds the null check), so DockHost gets a working LayoutStore either way. The section now describes what does happen: the default layout first, the saved one re-applied on workspace.onLoad. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DAiZN6XrTAdQpNN3eXEz2U
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shell.core README said that
DockHostfindsLayoutStorewithgetAdapter, which "does not create it", so the layout would silently never be saved. That's wrong:Adaptable.getAdapterconstructs a class-token adapter on first use, andrequireAdapteronly adds the null check (workspace.core/src/public/types/adaptable.ts). The section now describes what actually happens: the default layout appears first, and the saved one is re-applied onworkspace.onLoad.Docs only.
🤖 Generated with Claude Code
https://claude.ai/code/session_01DAiZN6XrTAdQpNN3eXEz2U