Repository navigation
Only shuffle when fork is installed - #142
Merged
Merged
Conversation
Keep it all consistent
Save polluting the generate method parameters. Should make merging easier
…ual-url-rendering
…ual-url-rendering
jesseleite
marked this pull request as draft
July 13, 2023 21:20
jasonvarga
marked this pull request as ready for review
July 14, 2023 13:42
jasonvarga
approved these changes
Jul 14, 2023
thomaskenne
pushed a commit
to thomaskenne/ssg
that referenced
this pull request
Feb 10, 2024
Co-authored-by: Simon Hamp <simon.hamp@me.com> Co-authored-by: Jason Varga <jason@pixelfear.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shuffling is intentional for balancing concurrent worker performance, but a good point was made in #136 (comment) about running non-deterministically and trying to work through page errors while generating a site.
Though we now have #137 to help with this type of workflow, the unpredictability of a shuffle only benefits the user when running concurrently with spatie/fork. This PR ensures the shuffle only happens when spatie/fork is detected.