[6.x] Forms 2: Generate field handles from labels - #15203
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request changes how field handles work in the form builder. Previously, when you added a field, Statamic would generate a random ID for its handle, rather than "slugifying" the label like the blueprint builder does.
The motivation for random IDs was that changing a field's label later wouldn't leave it with a stale, mismatched handle — with Forms 2.0, we really want people to use the
{{ fields }}loop to dynamically render fields, rather than hard coding fields, which isn't practical when clients might be editing forms. However, over time, the random handles have become a little awkward:This PR fixes it by generating handles from labels, like the blueprint builder:
date,messageandmessages), as per the docs.Warning
Forms created before this PR will have randomly generated handles. Any handle starting with a digit will now fail validation when saving the form, so you may need to fix up or recreate fields on existing forms.