Repository navigation
Release: multi-chain convert, slippage guard, live estimation - #118
Open
stackdapp-dev wants to merge 7 commits into
Open
stackdapp-dev wants to merge 7 commits into
stackdapp-dev wants to merge 7 commits into
Conversation
- Add editable Max Slippage input (default 1.0%) in exchange rate card - Change Fee display to show 0.3% crossed out with FREE in green Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- useGaslessSwap accepts maxSlippagePct param (default 1.0%) - Before signing, compares fresh quote buyAmount against original quote - Rejects swap if price moved beyond user's max slippage tolerance - Convert page passes user-configured slippage to the hook Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Extract slippage validation into pure exported function for testability - Add 17 unit tests covering: within tolerance, exceeds tolerance, edge cases - Verify implementation wiring (hook accepts param, executeSwap calls validator, page passes value) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Add calculateQuoteSlippage() pure function comparing quote rate vs market USD prices - Show Est. Slippage in exchange rate card (red when exceeding max) - Disable convert button with dull red "Try Lower Slippage" when slippage exceeded - 17 TDD unit tests: basic calc, XAUT/ETH swaps, edge cases, UI integration verification - Tests written first (red), then implementation (green), verified full suite Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Integration tests were timing out locally because the skip condition only applied in CI. Now skips whenever ETHEREUM_RPC_URL (or NEXT_PUBLIC_ETHEREUM_RPC_URL) is not set, preventing flaky timeouts on public rate-limited endpoints. Also updates CLAUDE.md with feature integration branch workflow. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Updates all UI-facing strings, alt text, page title, web manifest, and corresponding tests to reflect the ArCa brand name. https://claude.ai/code/session_01F7b6onmvAupSp1hhqdLehM Co-authored-by: stackdapp-dev <dev@stackdapp.co> Co-authored-by: Claude <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
calculateQuoteSlippage(basic calc, XAUT/ETH, edge cases, UI wiring)validateSlippage(tolerance, exceeded, edge cases)🤖 Generated with Claude Code