Skip to content

feat: Add a new cluster state "Unhealthy" - #63

Merged
sbernauer merged 16 commits into
mainfrom
feat/add-unhealthy-state
Feb 28, 2025
Merged

feat: Add a new cluster state "Unhealthy"#63
sbernauer merged 16 commits into
mainfrom
feat/add-unhealthy-state

Conversation

@sbernauer

@sbernauer sbernauer commented Feb 24, 2025

Copy link
Copy Markdown
Member

Part of #58

@sbernauer
sbernauer marked this pull request as draft February 24, 2025 13:41
@sbernauer sbernauer changed the title Feat/add unhealthy state feat: Add a new cluster state "Unhealthy" Feb 24, 2025
@sbernauer
sbernauer marked this pull request as ready for review February 24, 2025 15:34
@Techassi
Techassi self-requested a review February 24, 2025 15:36

@Techassi Techassi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feature overall lgtm, just a few questions and comments.

Comment thread CHANGELOG.md Outdated
Comment thread trino-lb/src/scaling/mod.rs Outdated
Comment thread trino-lb/src/maintenance/query_count_fetcher.rs
Comment thread trino-lb/src/maintenance/query_count_fetcher.rs
Comment thread trino-lb/src/maintenance/query_count_fetcher.rs
@sbernauer
sbernauer requested a review from Techassi February 25, 2025 10:11
@sbernauer sbernauer self-assigned this Feb 26, 2025

@Techassi Techassi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest changes look nice, just two small suggestions.

Comment thread CHANGELOG.md Outdated
Comment thread trino-lb/src/maintenance/query_count_fetcher.rs Outdated
@sbernauer
sbernauer requested a review from Techassi February 27, 2025 08:55
@sbernauer
sbernauer added this pull request to the merge queue Feb 28, 2025
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Feb 28, 2025
Merged via the queue into main with commit f067322 Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants