Various fixes and improvements to the bulk-pr scripts - #130
Merged
Conversation
lfrancke
commented
Aug 18, 2026
lfrancke
commented
Member
- All scripts now also work when not called from within the bulk-pr directory
- pr_status always reported 0, whatever the checks did - it read the exit code of "set -e" instead of the one from gh
- pr_close compared strings with -eq, which is an arithmetic comparison, so every PR looked OPEN
- All scripts would abort if a repo had no PR - the proper handling of that is moved to a new "common" file
- Closing a PR also deletes the old branches
- All scripts now also work when _not_ called from within the bulk-pr directory - pr_status always reported 0, whatever the checks did - it read the exit code of "set -e" instead of the one from gh - pr_close compared strings with -eq, which is an arithmetic comparison, so every PR looked OPEN - All scripts would abort if a repo had no PR - the proper handling of that is moved to a new "common" file - Closing a PR also deletes the old branches
dervoeti
self-requested a review
August 19, 2026 13:21
dervoeti
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
dervoeti
approved these changes
Aug 19, 2026
lfrancke
moved this from Development: In Review
to Development: Done
in Stackable Engineering
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.