feat: Add kube-http-proxy and kube-socks5 Cargo features - #1269
Merged
Conversation
The default features are unchanged. This allows us to enable these features in stackablectl (and elsewhere). Instead of ignoring a HTTP(S)_PROXY variable kube just refuses to build a client if it sees them but not the feature.
Member
Afair, it was not. It most likely slipped by unnoticed. |
Techassi
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
lfrancke
enabled auto-merge
September 3, 2026 09:22
Techassi
approved these changes
Sep 3, 2026
Techassi
moved this from Development: In Review
to Development: Done
in Stackable Engineering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The default features are unchanged.
This allows us to enable these features in stackablectl (and elsewhere). Instead of ignoring a HTTP(S)_PROXY variable kube just refuses to build a client if it sees them but not the feature.
We moved stackablectl to a direct dependency on operator-rs in March via stackabletech/stackablectl#426
That PR unfortunately also dropped support for HTTP/SOCKS proxy. I cannot find any evidence of this being a concious choice.
When this is merged and released we can enable the feature in stackablectl.
Reported on Discord: https://discordapp.com/channels/796665978481803304/1078284084247265300/1544734994856026193
Definition of Done Checklist
Reviewer