ci: Fix zizmor warnings and bump actions - #447
Open
Saul-STFC wants to merge 1 commit into
Open
Conversation
Techassi
changed the title
Techassi
approved these changes
Aug 31, 2026
| notify: | ||
| name: Failure Notification | ||
| needs: [build, publish_manifests] | ||
| permissions: {} |
Member
There was a problem hiding this comment.
I'm curious why we need to explicitly set an empty set of permissions here, if the workflow-wide default is empty as well ({}).
Comment on lines
+98
to
+99
| # Pinned to the latest v1.x patch, not v4 (latest): v2+ has breaking changes | ||
| - uses: slackapi/slack-github-action@fcfb566f8b0aab22203f066d80ca1d7e4b5d05b3 # v1.27.1 |
Member
There was a problem hiding this comment.
We should switch to our own stackabletech/send-slack-notification action in a follow-up PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR explicitly defines permissions fixing zizmor warnings and also bumps deps