Repository navigation
fix(ci): run driver suites for pin changes - #931
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f2ec5a8d96
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
f2ec5a8 to
101b346
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
101b346 to
dadede8
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
dadede8 to
a54cb04
Compare
|
Rebased the same patch onto master @codex review |
What changed
Moves the test path classifier into a small shell helper and routes
drivers/BUNDLED_SOURCE.jsonthrough both the core and driver suites.Why
The generic
drivers/*rule matched the pin first. A pin-only change ran core but skippeddriversanddrivers build from the pin alone.Validation
bash scripts/test-change-classifier.shgo run github.com/rhysd/actionlint/cmd/actionlint@v1.7.9 .github/workflows/test.ymlmake verifyThe contract test covers the former failing pin-only route.