Repository navigation
fix(ci): gate release workflow on successful test run - #81
Merged
Merged
Conversation
semantic-release was racing `go test + vet` — both workflows triggered
on `push:master` in parallel, so the changelog commit + tag push landed
before the test job finished and GitHub's branch protection rejected
it with GH006 ("Required status check 'go test + vet' is expected").
Switch release.yml's trigger to `workflow_run` on the `test` workflow
and guard the semantic-release job with
`conclusion == 'success'`. `workflow_dispatch` stays wired for manual
re-runs (event has no `workflow_run` payload — gate on event name too).
The downstream `binaries` + `docker` jobs already gate on
`needs.release.outputs.new_release_published`, so no extra `if:` needed
there.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
semantic-release was racing
go test + vet— both workflows triggered onpush:masterin parallel, so the changelog commit + tag push landed before the test job finished and GitHub's branch protection rejected it with GH006 ("Required status check 'go test + vet' is expected").Switch release.yml's trigger to
workflow_runon thetestworkflow and guard the semantic-release job withconclusion == 'success'.workflow_dispatchstays wired for manual re-runs (event has noworkflow_runpayload — gate on event name too).The downstream
binaries+dockerjobs already gate onneeds.release.outputs.new_release_published, so no extraif:needed there.