Repository navigation
fix(control): let battery charging yield to the EV - #1672
Merged
Merged
Conversation
Signed-off-by: Fredrik Ahlgren <fredrik@sourceful-labs.com>
Signed-off-by: Fredrik Ahlgren <fredrik@sourceful-labs.com>
frahlg
marked this pull request as ready for review
October 16, 2026 17:29
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a24f3bec64
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: Fredrik Ahlgren <fredrik@sourceful-labs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and result
A brief loss of fuse headroom could pause an EV for five minutes after the headroom returned. Repeated phase readings could also drive a safe charging step down to zero. Meanwhile, newer EV feedback combined with an older site reading could let the home battery claim power the car had already taken.
Keep the car's current charging request through the fuse clamp so optional home battery charging yields first. Resume after two safe control ticks, trim to a legal charging step, and recalculate the EV limit from measured headroom. A stopped or completed car releases its old plan reservation.
Scope and safety
main.goanddispatch.goonly wire the charging request snapshot and add the final battery cap; they leave the PV work in fix(control): mitigate PV-only export over limits #888 and other open feature branches intact.Verification
Regression coverage includes startup, NaN and missing power, stale-to-fresh recovery, repeated phase readings, one- and three-phase charging, empty phase settings, manual-to-scheduled transitions, concurrent phase changes, Stop, completed goals, two chargers sharing one cap, late or ignored battery reductions, pending orders, source timestamps, fixed poll order, AC/DC power differences and recovery without an initial shared sample. Joined tests check the physical power sum at command time, including 600 generated load combinations and different device response orders.
make verifypasses on the final source: Go tests, vet/build, protocol boundaries, release checks and the native Energyplan integration.Confirmation on the customer's charger and Pixii remains a beta field check.
Checklist