Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
frahlg
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Live-history and forecast failures report total phase time, which can combine many short steps. Archive and rollup failures can return only
context deadline exceeded, leaving connection, preparation, lock waits and writes indistinguishable.Add the longest step and step count to the existing bounded phase timer. Use that timer for archive connection, busy-timeout setup, BEGIN, preparation, archive-view lock, writer lock, write and commit. Capture failures before rollback, busy-timeout restoration and connection close. The phases retain the twelve-slot limit and contain no new sample values, SQL parameters or batch IDs. A phase can contain several SQL operations.
This adds diagnosis. It does not establish the field timeout's cause or change SQL, deadlines, FULL sync, queues, retry rules or cleanup order. The home box still runs the published beta; native merge, release and update remain with the assigned release thread.
Validation:
f4bfff6991704bd454e94d5c831b62e69d8830bdand pass after the change. They check connection, preparation, both locks and write, preserved committed rows, no SQL contents in the timing fields, and a successful retry.make verifypasses.f6ba8176; test run 38495649707 binds the exact head. The earlier automated review applies only tod39a1fe.