Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and change
A CLI full-backup request sends
{}. When its HTTP/1 connection closes, Core can keep copying and publish the archive because the handler has not read the body. Separate HTTP backup verification has the same unread-body issue, andInspect(ctx, ...)also dropped the caller context during full archive verification.Read the ignored create/verify body with the existing 1 MiB API limit before acquiring operation locks. An unreadable body returns 400; an oversized body returns 413 before work starts. Pass the caller context through the full
Inspectverification, as well as the final archive hash, so cancellation releases the verification workspace and backup lock. Create also releases its update lock. SQL, durability, deadlines, retry and backup pacing stay unchanged.Validation
.142.1before the fix. The two added verify regressions also fail on that source: oversized JSON reaches archive lookup, and a canceled inspection parses the archive.make verifypasses..142.1Core/CLI on an own 250000-row copy keeps JSON/CLI creation running after SIGINT; empty POST cancels. A separate valid archive with 512 MiB of synthetic padding shows JSON verification writing metadata after SIGINT.These are isolated copy/protocol checks on a virtual SSD. They do not prove Raspberry Pi backup throughput, the old household request’s exact network behavior, or the first household write-delay cause. No box runtime, release or version changed.