Repository navigation
Conversation
CLAUDE.md only pointed at AGENTS.md. The agent rules now stand on their own. The FTWDB page and the retired socket flag claimed DuckDB stores history; current Core stores it in SQLite.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c88fe8bed5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1,3 +0,0 @@ | |||
| @AGENTS.md | |||
There was a problem hiding this comment.
In standard Claude Code sessions opened at this checkout, project instructions are discovered through CLAUDE.md, not the newly asserted sentence in AGENTS.md; deleting this import therefore causes Claude to miss the repository's safety, release, and coordination rules. Retain the small @AGENTS.md shim so Claude actually follows the sole canonical guide.
AGENTS.md reference: AGENTS.md:L274-L274
Useful? React with 👍 / 👎.
miravoss26
left a comment
miravoss26
left a comment
There was a problem hiding this comment.
Docs and comment cleanup: removes the root CLAUDE.md, rewords the FTWDB retirement notes to say history lives in SQLite, and updates the help string on the retired -ftwdb-shadow-socket flag. The only code touched is that flag description.
- [blocking, CI is red because of this] contract/push-catalogue.yaml:5: this edits a comment in a file that lives byte-identical in the app repo. The "registry has not drifted from the app" check fails on a real diff: the app's copy still says "stated in CLAUDE.md since the beginning". The check's own instruction is to change both copies in a pair of PRs and rerun
go generate ./internal/.... Either drop this hunk here, or make the same edit in the app repo in a paired PR. - [question] AGENTS.md:274, CLAUDE.md: as far as I know Claude Code loads CLAUDE.md, not AGENTS.md. With the root CLAUDE.md gone, does a Claude session in this repo still pick up these rules? The new sentence says Claude follows AGENTS.md directly, so worth confirming.
- Verified: the doc claim that release builds have no DuckDB dependency holds,
go.modhas no duckdb on this branch or on the default branch. The new link todocs/history-conversion.mdresolves. Security screen clean.
Needs a human decision on the paired file before this can go green. The rest reads correct.
2 participants
Summary
CLAUDE.md.AGENTS.mdis the only agent guide, and it already matches the product rules inVISION.md: local planning, Core validates before hardware, novice default with expert access, beta then stable, no edge channel.docs/ftwdb-shadow.mdand the retired-ftwdb-shadow-sockethelp text. They said DuckDB owns history. Current Core and the architecture doc store history in SQLite. DuckDB remains only the offline converter for boxes that once selected it.upgrade-from-legacy.md,upgrade-paired-release.md,rpi-image.md). They still tell operators not to use those installers.AGENTS.mdin a different section.Test
Documentation and a retired flag's help string. No behavior change beyond the help text.