Skip to content

chore(ci): replace SourceKnight with setup-sp - #31

Merged
Rushaway merged 1 commit into
masterfrom
chore/drop-sourceknight
Aug 18, 2026
Merged

chore(ci): replace SourceKnight with setup-sp#31
Rushaway merged 1 commit into
masterfrom
chore/drop-sourceknight

Conversation

@Rushaway

Copy link
Copy Markdown
Member

Summary

  • Replace the SourceKnight-based CI (maxime1907/action-sourceknight) with native GitHub Actions steps.
  • Compile with spcomp via rumblefrog/setup-sp@v1.3.1, pinned to SourceMod 1.12.x.
  • Dependencies (sm-plugin-basic, sm-plugin-MultiColors, sm-ext-ripext, sm-ext-AsyncSocket) are now cloned directly from their source repos in the workflow instead of being resolved via sourceknight.yaml, which has been removed.
  • Package/release steps are unchanged in behavior: builds are packaged and uploaded as artifacts, and pushes to master/main (or tags) auto-release under the latest tag.
  • Updated .github/copilot-instructions.md to reflect the new build process and removed the stale .sourceknight entry from .gitignore.

Test plan

  • Confirm the CI workflow run on this PR compiles SMJSONAPI.sp successfully and uploads the build artifact.

Copilot AI lite review requested due to automatic review settings August 17, 2026 18:42

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Rushaway
Rushaway force-pushed the chore/drop-sourceknight branch from 90914bd to 5c0dd96 Compare August 18, 2026 08:05
@Rushaway
Rushaway merged commit f1be0e1 into master Aug 18, 2026
6 checks passed
@Rushaway
Rushaway deleted the chore/drop-sourceknight branch August 18, 2026 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants