Skip to content

[go-borges] Fix tests in integration #857

New issue
New issue
Closed
Closed
[go-borges] Fix tests in integration#857
Assignees
jfontan

Description

@jfontan
jfontan
opened on Jun 12, 2019
  • Create branch in gitbase repository with the initial integration from https://github.com/jfontan/gitbase/tree/go-borges-go-rebased is go-borges-integration
  • Tests from cmd/gitbase/command/server_test.go are still not modified to use go-borges. I'm not sure these are needed anymore.
  • Tests that use closedSiva can not work with go-borges (testTableIndexIterClosed and testTableIterClosed). They may be moved to go-borges.
  • TestRefsIterSiva fails and I'm not sure what's needed to make it work.
--- FAIL: TestRefsIterSiva (0.00s)
    --- FAIL: TestRefsIterSiva/all_refs (0.00s)
        require.go:97: 
            	Error Trace:	squash_iterator_test.go:989
            	Error:      	element [/home/jfontan/work/gitbase/_testdata/05893125684f2d3943cd84a7ab2b75e53668fba1.siva HEAD dbfab055c70379219cbcf422f05316fdf4e1aed3] appears more times in [[/home/jfontan/work/gitbase/_testdata/05893125684f2d3943cd84a7ab2b75e53668fba1.siva HEAD dbfab055c70379219cbcf422f05316fdf4e1aed3] [/home/jfontan/work/gitbase/_testdata/05893125684f2d3943cd84a7ab2b75e53668fba1.siva refs/heads/master dbfab055c70379219cbcf422f05316fdf4e1aed3]] than in [[015da2f4-6d89-7ec8-5ac9-a38329ea875b HEAD dbfab055c70379219cbcf422f05316fdf4e1aed3] [015da2f4-6d89-7ec8-5ac9-a38329ea875b refs/heads/master dbfab055c70379219cbcf422f05316fdf4e1aed3]]
            	Test:       	TestRefsIterSiva/all_refs
    --- FAIL: TestRefsIterSiva/repo_refs (0.00s)
        require.go:97: 
            	Error Trace:	squash_iterator_test.go:989
            	Error:      	element [/home/jfontan/work/gitbase/_testdata/05893125684f2d3943cd84a7ab2b75e53668fba1.siva HEAD dbfab055c70379219cbcf422f05316fdf4e1aed3] appears more times in [[/home/jfontan/work/gitbase/_testdata/05893125684f2d3943cd84a7ab2b75e53668fba1.siva HEAD dbfab055c70379219cbcf422f05316fdf4e1aed3] [/home/jfontan/work/gitbase/_testdata/05893125684f2d3943cd84a7ab2b75e53668fba1.siva refs/heads/master dbfab055c70379219cbcf422f05316fdf4e1aed3]] than in [[015da2f4-6d89-7ec8-5ac9-a38329ea875b HEAD dbfab055c70379219cbcf422f05316fdf4e1aed3] [015da2f4-6d89-7ec8-5ac9-a38329ea875b refs/heads/master dbfab055c70379219cbcf422f05316fdf4e1aed3]]
            	Test:       	TestRefsIterSiva/repo_refs
    --- FAIL: TestRefsIterSiva/remote_refs (0.00s)
        require.go:97: 
            	Error Trace:	squash_iterator_test.go:1013
            	Error:      	element [/home/jfontan/work/gitbase/_testdata/05893125684f2d3943cd84a7ab2b75e53668fba1.siva HEAD dbfab055c70379219cbcf422f05316fdf4e1aed3] appears more times in [[/home/jfontan/work/gitbase/_testdata/05893125684f2d3943cd84a7ab2b75e53668fba1.siva HEAD dbfab055c70379219cbcf422f05316fdf4e1aed3] [/home/jfontan/work/gitbase/_testdata/05893125684f2d3943cd84a7ab2b75e53668fba1.siva refs/heads/master dbfab055c70379219cbcf422f05316fdf4e1aed3] [/home/jfontan/work/gitbase/_testdata/05893125684f2d3943cd84a7ab2b75e53668fba1.siva HEAD dbfab055c70379219cbcf422f05316fdf4e1aed3] [/home/jfontan/work/gitbase/_testdata/05893125684f2d3943cd84a7ab2b75e53668fba1.siva refs/heads/master dbfab055c70379219cbcf422f05316fdf4e1aed3] [/home/jfontan/work/gitbase/_testdata/05893125684f2d3943cd84a7ab2b75e53668fba1.siva HEAD dbfab055c70379219cbcf422f05316fdf4e1aed3] [/home/jfontan/work/gitbase/_testdata/05893125684f2d3943cd84a7ab2b75e53668fba1.siva refs/heads/master dbfab055c70379219cbcf422f05316fdf4e1aed3]] than in [[015da2f4-6d89-7ec8-5ac9-a38329ea875b HEAD dbfab055c70379219cbcf422f05316fdf4e1aed3] [015da2f4-6d89-7ec8-5ac9-a38329ea875b refs/heads/master dbfab055c70379219cbcf422f05316fdf4e1aed3] [015da2f4-6d89-7ec8-5ac9-a38329ea875b HEAD dbfab055c70379219cbcf422f05316fdf4e1aed3] [015da2f4-6d89-7ec8-5ac9-a38329ea875b refs/heads/master dbfab055c70379219cbcf422f05316fdf4e1aed3] [015da2f4-6d89-7ec8-5ac9-a38329ea875b HEAD dbfab055c70379219cbcf422f05316fdf4e1aed3] [015da2f4-6d89-7ec8-5ac9-a38329ea875b refs/heads/master dbfab055c70379219cbcf422f05316fdf4e1aed3]]
            	Test:       	TestRefsIterSiva/remote_refs

Activity

  1. jfontan commented on Jun 13, 2019

    @jfontan
    jfontan
    on Jun 13, 2019
    ContributorAuthor

    Now there's a branch in gitbase go-borges-integration.

  2. kuba--
    assigned
    kuba--
    and unassigned
    kuba--
    on Jun 17, 2019
  3. erizocosmico
    assigned
    erizocosmico
    and unassigned
    erizocosmico
    on Jun 18, 2019
  4. jfontan
    self-assigned this
    on Jun 18, 2019

  5. jfontan commented on Jun 21, 2019

    @jfontan
    jfontan
    on Jun 21, 2019
    ContributorAuthor

    Fixed in #888

  6. jfontan
    closed this as completedon Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions