Skip to content

Docs: Clarified http_access scope w.r.t. X.509 AIA - #2490

Open
rousskov wants to merge 1 commit into
squid-cache:masterfrom
measurement-factory:SQUID-1177-x509-aia-access-docs
Open

Docs: Clarified http_access scope w.r.t. X.509 AIA#2490
rousskov wants to merge 1 commit into
squid-cache:masterfrom
measurement-factory:SQUID-1177-x509-aia-access-docs

Conversation

@rousskov

Copy link
Copy Markdown
Contributor

A security researcher has incorrectly claimed that Squid AIA fetching
feature comes with "zero protections". This additional documentation may
help avoid creating that false impression: Our http_access directive
does apply to internally-generated requests for missing certificates.
For example, if a Squid instance is correctly configured to deny access
to some local resource, that configuration will prohibit such access via
specially crafted AIA extensions as well.

Also detailed certificate-fetching option of the
transaction_initiator ACL to assist admins that need to customize
access policies for internally-generated X.509 AIA requests.

A security researcher has incorrectly claimed that Squid AIA fetching
feature comes with "zero protections". This additional documentation may
help avoid creating that false impression: Our `http_access` directive
does apply to internally-generated requests for missing certificates.
For example, if a Squid instance is correctly configured to deny access
to some local resource, that configuration will prohibit such access via
specially crafted AIA extensions as well.

Also detailed `certificate-fetching` option of the
`transaction_initiator` ACL to assist admins that need to customize
access policies for internally-generated X.509 AIA requests.

@kinkie kinkie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yadij yadij left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One small nit, but not insisting on it for merge.

Comment thread src/cf.data.pre
DEFAULT_DOC: Deny, unless rules exist in squid.conf.
DOC_START
Allowing or Denying access based on defined access lists
Controls HTTP and FTP requests access to this Squid instance.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would phrase that more like:

Suggested change
Controls HTTP and FTP requests access to this Squid instance.
Controls whether Squid is allowed to process an HTTP(S) or FTP request message.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not like my "controls access" version1, but I dislike proposed "allowed to process" variation even more because parsing the request, denying access to that request, and responding to that denied request while obeying deny_info settings (among many other actions!) is all request "processing". We need a more specific word.

Footnotes

  1. Because my version repeats the same "access" word that is already present in the directive name instead of helping a reader unfamiliar with access controls (or a reader with weak English skills) by using a different word that the reader may recognize.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants