Repository navigation
test(compiler): run reference service query shapes and rejections - #78
Merged
omer-cengel merged 1 commit intoOct 11, 2026
Conversation
Add an eleventh reference migration with a task assignee, a soft-deleted user column, and a partial unique handle index, mirrored in the snapshot, and eleven queries that run through the generated repository against PostgreSQL 16: a dynamic sort and cast page, EXISTS, IN (SELECT ...), and scalar subqueries, composite-key and filtered left joins, untargeted, named-constraint, and predicated conflict clauses, DO UPDATE ... WHERE, and an aliased RETURNING. Add an unsupported query catalogue with one file per rejected shape, each asserted with its whole located diagnostic and no generated output, and list the new tests in the query and PostgreSQL documentation.
omer-cengel
deleted the
chore/reference-service-query-shapes-and-unsupported-catalogue
branch
October 11, 2026 21:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the reference service so the query shapes sqlcj now accepts run against PostgreSQL 16 through the generated repository, and so every shape that stays unsupported is pinned to its exact located diagnostic. No production code changes.
Changes
tasks.assignee_idreferencinguserswithON DELETE SET NULL, ausers.deleted_atsoft-delete column, and a partial unique index on(organization_id, handle) WHERE deleted_at IS NULL. The migration history, the snapshot, and thepg_dumpsnapshot still generate one byte-identical, compiling tree.ORDER BY CASEsort in both modes and a castLIMIT/OFFSETpage;EXISTS,IN (SELECT ...), and scalar-subquery queries with cast placeholders;ON CONFLICT DO NOTHING, and anON CONFLICT ON CONSTRAINT ... DO UPDATE ... WHEREthat skips an unchanged role;RETURNING.RIGHT,FULL,USING,NATURAL,CROSS, comma, andLATERALjoins, a CTE source, aFROMsubquery, multi-rowVALUES,INSERT ... SELECT,UPDATE ... FROM,DELETE ... USING, an uncastlower(:email), and an uncast placeholder beside a subscripted column. Each entry is asserted with its whole located diagnostic and no generated output, and the catalogue directory is asserted to hold exactly those files.Verified bysections of the query and PostgreSQL documentation.Scope and non-goals