Polish README - #450
Closed
scordio wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Stefano Cordio <stefano.cordio@gmail.com>
wilkinsona
reviewed
Jun 23, 2025
| By default, tabs are used for indenting formatted code. | ||
| We strongly recommend that this default is not changed, especially for official Spring projects. | ||
| If, however, you feel that you can't live with tabs then switching to spaces is the one configuration option that we do support. | ||
| If, however, you feel that you can't live with tabs, then switching to spaces is the one configuration option that we do support. |
Contributor
There was a problem hiding this comment.
A comma isn't needed with "then" so this should either be "… live with tabs then switching …" or "… live with tabs, switching". Given the style elsewhere, I think the latter's better. We can make that tweak as part of merging.
Contributor
Author
There was a problem hiding this comment.
Oh yes, somehow I missed deleting the "then" in my proposal. Thanks for taking care of that!
wilkinsona
changed the title
wilkinsona
pushed a commit
that referenced
this pull request
Jun 23, 2025
Signed-off-by: Stefano Cordio <stefano.cordio@gmail.com> See gh-450
wilkinsona
added a commit
that referenced
this pull request
Jun 23, 2025
Contributor
|
Thanks very much, @scordio. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I initially just wanted to fix the level of the Maven's Checkstyle section:
Eventually, I fixed some typos and made small adjustments that I think can improve README's readability 🙂
Of course, feel free to drop them if you don't like them!