Cleanup - #1

Merged

aledbf merged 80 commits into

mainfrom

Dec 31, 2025

Commits on Dec 30, 2025

fix(resources): use conservative 4GB default instead of 256GB
aledbf
committed
bcbde1a
fix(network): correct defer order for netns handles
aledbf
committed
99bc051
fix(shim): correct defer order for mount namespace handle
aledbf
committed
05d4a16
fix(qemu): replace panic with error return in buildQemuCommandLine
aledbf
committed
07706c9
fix(vminit): handle error instead of discarding in Process() call
aledbf
committed
1769135
fix(memhotplug): elevate re-online failure log from Warn to Error
aledbf
committed
1a05fbe
fix(mounts): return actual error instead of ErrNotImplemented
aledbf
committed
37f8290
fix(vminit): add cleanup for container when post-create steps fail
aledbf
committed
d304464
refactor(qemu): centralize TAP file descriptor cleanup
aledbf
committed
aa49c1e
fix(memhotplug): treat memory online failure as error, not warning
aledbf
committed
78169e6
fix(network): fail CNI parsing when no IP addresses allocated
aledbf
committed
acda43a
fix(network): cleanup netns file on catastrophic restore failure
aledbf
committed
0c2e71b
refactor(shim): use defer pattern for network cleanup in Create()
aledbf
committed
b8e580f
fix(cpuhotplug): validate all config durations before use
aledbf
committed
0121b6a
fix(cpuhotplug): make scaleDown return error consistently
aledbf
committed
3528c18
fix(shim): use typed error checking instead of string matching
aledbf
committed
d2a88c6
fix(lifecycle): use syscall errors instead of string matching for vsock
aledbf
committed
2ae4bd3
refactor(qmp): make execute() return response for future use
aledbf
committed
9d25d3d
Handle netns cleanup errors instead of ignoring
aledbf
committed
20d8496
Reduce repetitive cleanup code with helper function
aledbf
committed
d23c350
Update outdated comment about CPU target calculation
aledbf
committed
443ce6a
Correct contradictory comment about EnableScaleDown default
aledbf
committed
a6896c9
Elevate ctrl-alt-del config failure to error level
aledbf
committed
91af200
Avoid misleading success logs after teardown failures
aledbf
committed
a6017d4
Add warnings for time anomalies in CPU sampling
aledbf
committed
bb15ca9
Correct typo in tmpfs mount source string
aledbf
committed
e6361ee
Use 'any' instead of 'interface{}' for Go 1.18+ consistency
aledbf
committed
7ef707c
Add comment explaining blank import side effect
aledbf
committed
ee5f616
Replace interface{} with 'any' in QMP code
aledbf
committed
bdf7774
Remove unnecessary syscall wrappers
aledbf
committed
9ac7e07
Add container context to generic error messages
aledbf
committed
a2fb2e7
Extract repeated client close pattern to helper function
aledbf
committed
a663edc
Replace magic numbers with named constants
aledbf
committed
319a46c
Assert on error message content instead of just logging
aledbf
committed
22bc242
Fix formatting: Align struct field definitions for consistency
aledbf
committed
59b1a01
Replace magic number with named constant for memory slots
aledbf
committed
b41f0dc
Replace GOMAXPROCS magic number with named constant
aledbf
committed
fb2224f
Replace hard-coded retry sleep with named constant
aledbf
committed
5c33a02
Extract repeated tag truncation logic into helper function
aledbf
committed
5f82ef6
Replace dead virtiofs option translation code with stub
aledbf
committed
719016f
Replace hard-coded reconnect deadline with named constant
aledbf
committed
f28e52f
Replace magic numbers in DefaultConfig with named constants
aledbf
committed
a75215d
Deduplicate maxSlots magic number into package-level constant
aledbf
committed
2068a5d
Add validation to alignMemory for invalid alignment values
aledbf
committed
e1fd993
Add field documentation to proto message definitions
aledbf
committed
9f14d71
Add service-level and RPC documentation to proto services
aledbf
committed
5e945ec
Replace test file creation with unix.Access for write permission check
aledbf
committed
278724a
Fix race condition in CPU hotplug controller Start() method
aledbf
committed
186f615
Add double-start protection to memory hotplug controller
aledbf
committed
80ab436
Log silently swallowed config errors in paths package
aledbf
committed
a155f32
Remove misleading comment with redundant error discard
aledbf
committed
c345fdd
Make isVethConflictError case-insensitive as documented
aledbf
committed
03e578f
Make CPU scaleDown error handling consistent with scaleUp
aledbf
committed
7dc75e9
Extract duplicate closed-check pattern into helper method
aledbf
committed
ae3e4a9
Add test for config.Get() singleton behavior
aledbf
committed
cd4a218
Document API versioning strategy
aledbf
committed
2bd3cd3
Return errors instead of nil when VM is not available
aledbf
committed
c650108

Commits on Dec 31, 2025

Fix integration tests and linter issues after I-002 interface changes
aledbf
committed
004a7f5
Remove side effects from validation function
aledbf
committed
c07f9e4
Simplify LoadNetworkConfig fallback logic and add default for partial env override
aledbf
committed
179621d
Extract file scheme handling from setupForwardIO
aledbf
committed
4a4fa19
Extract duplicate config parsing logic into generic helper
aledbf
committed
4362f48
Eliminate TOCTOU race in CreateTask using atomic creation flag
aledbf
committed
72db9c0
Extract mock process into shared test helper
aledbf
committed
99e1084
Lint
aledbf
committed
7d884a3
Release mutex before closing network connection
aledbf
committed
e17b673
Make console FIFO goroutine cancellable
aledbf
committed
f57e9eb
Implement proper CPU cpuset parsing
aledbf
committed
80c94b2
Extract shared network types to common file
aledbf
committed
55fc6d9
Add comprehensive table-driven tests for config validation
aledbf
committed
e70a5a2
Document pivot root security implications
aledbf
committed
762ec82
Add ResetForTesting helper to improve config testability
aledbf
committed
4ae71f4
Decouple paths package from config singleton
aledbf
committed
385f94e
Add comprehensive resource cleanup verification tests
aledbf
committed
0006b38
Implement QEMU command builder pattern
aledbf
committed
843ee67
Extract Shutdown responsibilities into helper methods
aledbf
committed
cfe1239
Split vminitd/main.go into focused packages
aledbf
committed
52a2a9f
Split guest vminit task service.go into focused modules
aledbf
committed
3453a85
Split QEMU instance.go into focused modules
aledbf
committed
df5e581
Lint
aledbf
committed
a431b11