Repository navigation
Conversation
Count flags use NoOptDefVal, so --foo 2 leaves 2 as a positional argument while --foo=2 sets the value. Printing "count" as a required argument made the space-separated form look valid.
|
|
Author
|
Closing this PR as I will not be signing the CLA. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #267.
Count flags set
NoOptDefVal, so--foo 2increments once and leaves2as a positional argument, while--foo=2sets the count. Usage still printed a required-lookingcountargument, which made the space-separated form look valid.Print
--foo[=count]instead, matching other optional-value flags.Test plan
go test -race ./...TestCountUsageShowsOptionalValuefails on master (--foo count) and passes after the changeTestPrintDefaultsgolden updated for the verbose count flag