Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Cclark/fix migration graph - #48003

Merged
coury-clark merged 1 commit into
4.5from
cclark/fix-migration-graph
Feb 21, 2023
Merged

Cclark/fix migration graph#48003
coury-clark merged 1 commit into
4.5from
cclark/fix-migration-graph

Conversation

@coury-clark

Copy link
Copy Markdown
Contributor

MIgration graph was broken after latest backport

Test plan

N/A

@cla-bot cla-bot Bot added the cla-signed label Feb 21, 2023
@coury-clark
coury-clark requested a review from Strum355 February 21, 2023 22:48
@coury-clark
coury-clark changed the base branch from main to 4.5 February 21, 2023 22:48

@Strum355 Strum355 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did this pass CI 🤔

@coury-clark

coury-clark commented Feb 21, 2023

Copy link
Copy Markdown
Contributor Author

@Strum355 not sure! There might be a static reference somewhere instead of using the base branch

@sg-e2e-regression-test-bob

Copy link
Copy Markdown

Bundle size report 📦

Initial size Total size Async size Modules
0.00% (0.00 kb) 0.00% (+0.20 kb) 0.00% (+0.20 kb) 0.00% (0)

Look at the Statoscope report for a full comparison between the commits 5a34329 and e1ea5f6 or learn more.

Open explanation
  • Initial size is the size of the initial bundle (the one that is loaded when you open the page)
  • Total size is the size of the initial bundle + all the async loaded chunks
  • Async size is the size of all the async loaded chunks
  • Modules is the number of modules in the initial bundle

@coury-clark
coury-clark merged commit 42087de into 4.5 Feb 21, 2023
@coury-clark
coury-clark deleted the cclark/fix-migration-graph branch February 21, 2023 23:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants