This repository was archived by the owner on Sep 30, 2024. It is now read-only.
rbac: order columns for migration - #48001
Merged
Merged
Conversation
eseliger
approved these changes
Feb 21, 2023
courier-new
force-pushed
the
kr/migration-column-order
branch
from
February 21, 2023 22:47
5b1ad9f to
1828301
Compare
github-actions Bot
pushed a commit
that referenced
this pull request
Feb 22, 2023
Adds an explicit order to the columns for the roles insert statement to improve robustness when running migrations up and down. (cherry picked from commit 69c7f65)
Contributor
|
Thank you! |
coury-clark
pushed a commit
that referenced
this pull request
Feb 22, 2023
eseliger
referenced
this pull request
Feb 22, 2023
Forgot to run `sg generate` for https://github.com/sourcegraph/sourcegraph/pull/48001. 🙈
github-actions Bot
referenced
this pull request
Feb 22, 2023
Forgot to run `sg generate` for https://github.com/sourcegraph/sourcegraph/pull/48001. 🙈 (cherry picked from commit 3191fdb)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an explicit order to the columns for the roles insert statement to improve robustness when running migrations up and down.
Test plan
Ran migrations down to well before
1671543381_add_default_rolesthen back up successfully.