This repository was archived by the owner on Sep 30, 2024. It is now read-only.
packages: remove reference to to-be-removed column in code and use default value instead - #47969
Merged
Merged
Conversation
…fault value instead
Strum355
added
team/graph
efritz
approved these changes
Feb 21, 2023
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 72471c2...449b1da.
|
github-actions Bot
pushed a commit
that referenced
this pull request
Feb 21, 2023
…fault value instead (#47969) We should not be referencing the `version` column from `lsif_dependency_repos` if we plan to remove it in a later migration. Given we were only inserting a default value anyways, we should just use a default value in postgres instead. Then is safe 👍 ## Test plan Migration runs fine, no more references found in code, ran locally (cherry picked from commit f9b7f74)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should not be referencing the
versioncolumn fromlsif_dependency_reposif we plan to remove it in a later migration. Given we were only inserting a default value anyways, we should just use a default value in postgres instead. Then is safe 👍Test plan
Migration runs fine, no more references found in code, ran locally