This repository was archived by the owner on Sep 30, 2024. It is now read-only.
web: migrate user settings routes - #47451
Merged
valerybugakov merged 9 commits intoFeb 9, 2023
Merged
Conversation
github-actions
Bot
added
the
team/code-exploration
57 tasks
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 1157577...01a9075.
|
Contributor
|
Codenotify: Notifying subscribers in OWNERS files for diff 1157577...01a9075.
|
Member
Author
|
Percy is not happy, but I cannot repro the issue locally yet. Looking into it! |
philipp-spiess
approved these changes
Feb 8, 2023
| /> | ||
| } | ||
| /> | ||
| </Routes> |
| /> | ||
| {batchSpec.applyURL ? ( | ||
| <Routes> | ||
| <Route element={<Navigate to="execution" replace={true} />} index={true} /> |
Contributor
There was a problem hiding this comment.
Oh is there a difference between index={true} and path=""?
Member
Author
There was a problem hiding this comment.
Based on the documentation, it seems that index={true} is the recommended approach. From the functional point of view, I didn't notice any differences yet.
| import { BackToAllSubscriptionsLink } from './BackToAllSubscriptionsLink' | ||
| import { UserProductSubscriptionStatus } from './UserProductSubscriptionStatus' | ||
|
|
||
| interface Props extends Pick<RouteComponentProps<{ subscriptionUUID: string }>, 'match'> { |
Contributor
There was a problem hiding this comment.
It feels so good to get rid of this stuff everywhere 😅
valerybugakov
force-pushed
the
main-dry-run/vb/react-router-migration-user-settings
branch
from
February 9, 2023 08:32
25a0e9b to
01a9075
Compare
Member
Author
|
Fixed Percy! |
valerybugakov
deleted the
main-dry-run/vb/react-router-migration-user-settings
branch
February 9, 2023 09:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Test plan