Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

sg: propagate errors when running individual generate commands - #47436

Merged
ggilmore merged 1 commit into
mainfrom
sg-fix-error-reporting
Feb 7, 2023
Merged

sg: propagate errors when running individual generate commands#47436
ggilmore merged 1 commit into
mainfrom
sg-fix-error-reporting

Conversation

@ggilmore

@ggilmore ggilmore commented Feb 7, 2023

Copy link
Copy Markdown
Contributor

Before, error codes wouldn't not be properly propagated back to the main process if you ran an individual sg generate target (ex: sg generate buf) This small change fixes that.

Example output:

~/dev/go/src/github.com/sourcegraph/sourcegraph fix-error-reporting* ≡ 7s
base ❯ go run ./dev/sg  generate buf                                                                                                                                                                 (base) 16:17:08
❌ running "buf generate": exit status 100: searcher.proto:12:45:method searcher.v1.SearcherService.Search: unknown response type SearchResponsefff
exit status 1

Test plan

Manual testing.

@cla-bot cla-bot Bot added the cla-signed label Feb 7, 2023
@ggilmore
ggilmore marked this pull request as ready for review February 7, 2023 15:27
@ggilmore
ggilmore merged commit 4300b2c into main Feb 7, 2023
@ggilmore
ggilmore deleted the sg-fix-error-reporting branch February 7, 2023 15:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

No open projects
Status: Todo

Development

Successfully merging this pull request may close these issues.

2 participants