Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

rbac: add mutation for deleting a role - #47409

Merged
BolajiOlajide merged 3 commits into
mainfrom
bo/delete-role-mutation
Feb 8, 2023
Merged

rbac: add mutation for deleting a role#47409
BolajiOlajide merged 3 commits into
mainfrom
bo/delete-role-mutation

Conversation

@BolajiOlajide

Copy link
Copy Markdown
Contributor

Closes #45450

Test plan

  • Added unit tests
  • manually tested

@BolajiOlajide BolajiOlajide added batch-changes Issues related to Batch Changes rbac labels Feb 5, 2023
@BolajiOlajide
BolajiOlajide requested a review from a team February 5, 2023 21:45
@BolajiOlajide BolajiOlajide self-assigned this Feb 5, 2023
@cla-bot cla-bot Bot added the cla-signed label Feb 5, 2023

if len(errs) != 1 {
t.Fatalf("expected single errors, but got none")
t.Fatalf("expected a single error, but got %d", len(errs))

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleanup!

Comment thread cmd/frontend/graphqlbackend/rbac.graphql Outdated
Co-authored-by: Kelli Rockwell <kelli@sourcegraph.com>
@BolajiOlajide
BolajiOlajide merged commit 58d88b3 into main Feb 8, 2023
@BolajiOlajide
BolajiOlajide deleted the bo/delete-role-mutation branch February 8, 2023 15:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

batch-changes Issues related to Batch Changes cla-signed rbac

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RBAC: Implement mutation for deleting a role

2 participants