This repository was archived by the owner on Sep 30, 2024. It is now read-only.
insights: use escaped view title in data export filename - #47318
Merged
Conversation
added 2 commits
February 2, 2023 13:09
Contributor
Author
|
@vovakulikov the escapeRegexp helper you use doesn't behave the same as the backend one; for consistency sake is there a way to use the filename returned by the backend or do you define it prior to fetching the data? |
Bundle size report 📦
Look at the Statoscope report for a full comparison between the commits fc7c28f and 5c25cdf or learn more. Open explanation
|
leonore
marked this pull request as ready for review
February 2, 2023 17:54
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 5c25cdf...fc7c28f. No notifications. |
chwarwick
approved these changes
Feb 2, 2023
leonore
enabled auto-merge (squash)
February 7, 2023 12:12
leonore
disabled auto-merge
February 7, 2023 12:13
leonore
enabled auto-merge (squash)
February 7, 2023 12:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #46876
also add a link to data retention docs
Test plan
Tested through curl and UI export with a file with special characters (specifically
\which created folders prior)