Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

insights: use escaped view title in data export filename - #47318

Merged
leonore merged 4 commits into
mainfrom
insights/export-illegal-chars-filename
Feb 7, 2023
Merged

insights: use escaped view title in data export filename#47318
leonore merged 4 commits into
mainfrom
insights/export-illegal-chars-filename

Conversation

@leonore

@leonore leonore commented Feb 2, 2023

Copy link
Copy Markdown
Contributor

closes #46876

also add a link to data retention docs

Screenshot 2023-02-02 at 13 46 08

Test plan

Tested through curl and UI export with a file with special characters (specifically \ which created folders prior)

before after
Screenshot 2023-02-02 at 13 49 33 image

@leonore
leonore requested a review from vovakulikov February 2, 2023 13:50
@cla-bot cla-bot Bot added the cla-signed label Feb 2, 2023
@leonore

leonore commented Feb 2, 2023

Copy link
Copy Markdown
Contributor Author

@vovakulikov the escapeRegexp helper you use doesn't behave the same as the backend one; for consistency sake is there a way to use the filename returned by the backend or do you define it prior to fetching the data?

@sg-e2e-regression-test-bob

sg-e2e-regression-test-bob commented Feb 2, 2023

Copy link
Copy Markdown

Bundle size report 📦

Initial size Total size Async size Modules
0.00% (0.00 kb) 0.00% (+0.12 kb) 0.00% (+0.12 kb) 0.00% (0)

Look at the Statoscope report for a full comparison between the commits fc7c28f and 5c25cdf or learn more.

Open explanation
  • Initial size is the size of the initial bundle (the one that is loaded when you open the page)
  • Total size is the size of the initial bundle + all the async loaded chunks
  • Async size is the size of all the async loaded chunks
  • Modules is the number of modules in the initial bundle

@leonore
leonore marked this pull request as ready for review February 2, 2023 17:54
@sourcegraph-bot

sourcegraph-bot commented Feb 2, 2023

Copy link
Copy Markdown
Contributor

Codenotify: Notifying subscribers in CODENOTIFY files for diff 5c25cdf...fc7c28f.

No notifications.

@leonore
leonore enabled auto-merge (squash) February 7, 2023 12:12
@leonore
leonore disabled auto-merge February 7, 2023 12:13
@leonore
leonore enabled auto-merge (squash) February 7, 2023 12:13
@leonore
leonore merged commit b071425 into main Feb 7, 2023
@leonore
leonore deleted the insights/export-illegal-chars-filename branch February 7, 2023 12:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

insights: use code insight title for data export filename

4 participants