Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

grpc gitserver exec - #47290

Merged
camdencheek merged 16 commits into
mainfrom
cc/grpc-gitserver-exec
Feb 9, 2023
Merged

grpc gitserver exec#47290
camdencheek merged 16 commits into
mainfrom
cc/grpc-gitserver-exec

Conversation

@camdencheek

@camdencheek camdencheek commented Feb 1, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Test plan

Unit tests

@cla-bot cla-bot Bot added the cla-signed label Feb 1, 2023
@camdencheek
camdencheek changed the base branch from main to cc/add-streamio February 1, 2023 21:28
Base automatically changed from cc/add-streamio to main February 1, 2023 21:30
ggilmore
ggilmore reviewed Feb 1, 2023
View reviewed changes
Comment thread internal/gitserver/git_command.go Outdated
@ggilmore
ggilmore marked this pull request as ready for review February 2, 2023 19:09
@sourcegraph-bot

sourcegraph-bot commented Feb 2, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Codenotify: Notifying subscribers in CODENOTIFY files for diff 1ea14a2...9ec300b.

Notify File(s)
@indradhanush cmd/gitserver/server/server_grpc.go
internal/gitserver/client.go
internal/gitserver/client_test.go
internal/gitserver/git_command.go
@keegancsmith internal/debugserver/grpcui.go
internal/search/searcher/client_grpc.go
internal/symbols/client.go
@sashaostrikov cmd/gitserver/server/server_grpc.go
internal/gitserver/client.go
internal/gitserver/client_test.go
internal/gitserver/git_command.go

ggilmore and others added 6 commits February 2, 2023 13:28
@ggilmore
Update client.go
7aa1ef5
@ggilmore
Merge remote-tracking branch 'origin/main' into cc/grpc-gitserver-exec
ff90b40 
 Conflicts:
	cmd/gitserver/shared/shared.go
	internal/own/codeowners/v1/codeowners.pb.go
	internal/search/searcher/client_grpc.go
	internal/symbols/client.go
@camdencheek
remove unused imports
0946e7b
@camdencheek
fix imports
2f0aabe
@camdencheek
log and propagate error
9a95e57
@camdencheek @ggilmore
Apply suggestions from code review
07ea282 
Co-authored-by: Geoffrey Gilmore <geoffrey@sourcegraph.com>
@camdencheek

camdencheek commented Feb 7, 2023

Copy link
Copy Markdown
Contributor Author

Seeing some tests fail when the grpc flag is enabled. It seems to be because our tests create a server without wrapping it with a grpc handler.

@camdencheek
camdencheek requested a review from ggilmore February 8, 2023 23:38
@camdencheek
camdencheek enabled auto-merge (squash) February 8, 2023 23:38
@camdencheek
camdencheek merged commit 4d3db96 into main Feb 9, 2023
@camdencheek
camdencheek deleted the cc/grpc-gitserver-exec branch February 9, 2023 08:52
@ggilmore ggilmore mentioned this pull request Feb 15, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@ggilmore ggilmore ggilmore approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@camdencheek @sourcegraph-bot @ggilmore