fix: Propagate Locs instead of LocOffsets. - #98
Merged
Merged
Conversation
Fixes a crash when indexing Homebrew, where we were running into situations where we'd end up having a LocOffset for a nameLoc, and it'd be unclear which file it corresponded to. Trying to recover that information after the fact, such as from the method's Loc field, seemed unreliable, so I've chosen to carry a Loc instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes a crash when indexing Homebrew/brew, where we were running into
situations where we'd end up having a LocOffset for a nameLoc,
and it'd be unclear which file it corresponded to. Trying to
recover that information after the fact, such as from the method's
Loc field, seemed unreliable, so I've chosen to carry a Loc instead.
Test plan
Manually tested by indexing Hombrew/brew.