Skip to content

build: Bazel-ify builds of Gems. - #73

Merged
varungandhi-src merged 1 commit into
scip-ruby/masterfrom
vg/bazelify-gem-build
Aug 12, 2022
Merged

varungandhi-src merged 1 commit into
scip-ruby/masterfrom
vg/bazelify-gem-build

Conversation

@varungandhi-src

Copy link
Copy Markdown
Contributor

Motivation

  • Gem building no longer modifies the source tree.
  • It enables using the gems for repo tests.

Test plan

I will push a v0.0.2 tag after this to see if works.

@varungandhi-src
varungandhi-src force-pushed the vg/bazelify-gem-build branch 3 times, most recently from 4e255ea to b64be38 Compare August 12, 2022 08:12
Comment thread gems/scip-ruby/bin/scip-ruby Outdated

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would've been nice to have split this up into a different PR, but it seems like busywork right now, so not doing that.

- Gem building no longer modifies the source tree.
- It enables using the gems for repo tests.
@varungandhi-src
varungandhi-src merged commit 4e4e4c4 into scip-ruby/master Aug 12, 2022
@varungandhi-src
varungandhi-src deleted the vg/bazelify-gem-build branch August 12, 2022 08:27
varungandhi-src added a commit that referenced this pull request Aug 12, 2022
- Gem building no longer modifies the source tree.
- It enables using the gems for repo tests.
varungandhi-src added a commit that referenced this pull request Aug 12, 2022
- Gem building no longer modifies the source tree.
- It enables using the gems for repo tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant