build: Bazel-ify builds of Gems. - #73
Merged
Merged
Conversation
varungandhi-src
force-pushed
the
vg/bazelify-gem-build
branch
3 times, most recently
from
August 12, 2022 08:12
4e255ea to
b64be38
Compare
varungandhi-src
commented
Aug 12, 2022
Contributor
Author
There was a problem hiding this comment.
It would've been nice to have split this up into a different PR, but it seems like busywork right now, so not doing that.
- Gem building no longer modifies the source tree. - It enables using the gems for repo tests.
varungandhi-src
force-pushed
the
vg/bazelify-gem-build
branch
from
August 12, 2022 08:18
b64be38 to
d737e49
Compare
varungandhi-src
added a commit
that referenced
this pull request
Aug 12, 2022
- Gem building no longer modifies the source tree. - It enables using the gems for repo tests.
varungandhi-src
added a commit
that referenced
this pull request
Aug 12, 2022
- Gem building no longer modifies the source tree. - It enables using the gems for repo tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Test plan
I will push a v0.0.2 tag after this to see if works.