Skip to content

cfg: Fix type sizes in release build. #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
varungandhi-src merged 1 commit into from
Aug 10, 2022
Merged

cfg: Fix type sizes in release build. #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions cfg/Instructions.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ INSN(Send) : public Instruction {
std::string toString(const core::GlobalState &gs, const CFG &cfg) const;
std::string showRaw(const core::GlobalState &gs, const CFG &cfg, int tabs = 0) const;
};
CheckSize(Send, 120, 8);
CheckSize(Send, 144, 8);

INSN(Return) : public Instruction {
public:
Expand All @@ -172,7 +172,7 @@ INSN(Return) : public Instruction {
std::string toString(const core::GlobalState &gs, const CFG &cfg) const;
std::string showRaw(const core::GlobalState &gs, const CFG &cfg, int tabs = 0) const;
};
CheckSize(Return, 24, 8);
CheckSize(Return, 32, 8);

INSN(BlockReturn) : public Instruction {
public:
Expand All @@ -183,7 +183,7 @@ INSN(BlockReturn) : public Instruction {
std::string toString(const core::GlobalState &gs, const CFG &cfg) const;
std::string showRaw(const core::GlobalState &gs, const CFG &cfg, int tabs = 0) const;
};
CheckSize(BlockReturn, 32, 8);
CheckSize(BlockReturn, 40, 8);

INSN(LoadSelf) : public Instruction {
public:
Expand Down Expand Up @@ -282,7 +282,7 @@ INSN(YieldLoadArg) : public Instruction {
std::string toString(const core::GlobalState &gs, const CFG &cfg) const;
std::string showRaw(const core::GlobalState &gs, const CFG &cfg, int tabs = 0) const;
};
CheckSize(YieldLoadArg, 24, 8);
CheckSize(YieldLoadArg, 32, 8);

INSN(Cast) : public Instruction {
public:
Expand All @@ -300,7 +300,7 @@ INSN(Cast) : public Instruction {
std::string toString(const core::GlobalState &gs, const CFG &cfg) const;
std::string showRaw(const core::GlobalState &gs, const CFG &cfg, int tabs = 0) const;
};
CheckSize(Cast, 40, 8);
CheckSize(Cast, 48, 8);

INSN(TAbsurd) : public Instruction {
public:
Expand All @@ -314,7 +314,7 @@ INSN(TAbsurd) : public Instruction {
std::string toString(const core::GlobalState &gs, const CFG &cfg) const;
std::string showRaw(const core::GlobalState &gs, const CFG &cfg, int tabs = 0) const;
};
CheckSize(TAbsurd, 16, 8);
CheckSize(TAbsurd, 24, 8);

class InstructionPtr final {
using tagged_storage = uint64_t;
Expand Down
48 changes: 30 additions & 18 deletions scip-ruby.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,25 +8,37 @@

For more information about configurations, see the main [README](./README.md).

NOTE: In some Ubuntu instances (Ubuntu 22.04 image on Google Cloud),
there is a known build error with m4.
This problem doesn't happen with Ubuntu 20.04.

<details>
<summary>M4 build error due to sysconf not being defined</summary>

```
external/m4_v1.4.18/gnulib/lib/c-stack.c:55:26: error: function-like macro 'sysconf' is not defined
#elif HAVE_LIBSIGSEGV && SIGSTKSZ < 16384
^
/usr/include/x86_64-linux-gnu/bits/sigstksz.h:28:19: note: expanded from macro 'SIGSTKSZ'
# define SIGSTKSZ sysconf (_SC_SIGSTKSZ)
^
external/m4_v1.4.18/gnulib/lib/c-stack.c:139:8: error: fields must have a constant size: 'variable length array in structure' extension will never be supported
char buffer[SIGSTKSZ];
^
2 errors generated.
```
<summary>Known build issues</summary>

1. In some Ubuntu instances (Ubuntu 22.04 image on Google Cloud),
there is a known build error with m4.
This problem doesn't happen with Ubuntu 20.04.
```
external/m4_v1.4.18/gnulib/lib/c-stack.c:55:26: error: function-like macro 'sysconf' is not defined
#elif HAVE_LIBSIGSEGV && SIGSTKSZ < 16384
^
/usr/include/x86_64-linux-gnu/bits/sigstksz.h:28:19: note: expanded from macro 'SIGSTKSZ'
# define SIGSTKSZ sysconf (_SC_SIGSTKSZ)
^
external/m4_v1.4.18/gnulib/lib/c-stack.c:139:8: error: fields must have a constant size: 'variable length array in structure' extension will never be supported
char buffer[SIGSTKSZ];
^
2 errors generated.
```
2. A release build (`--config=release-mac`) fails on Apple Silicon Macs,
which (I think) is related to this upstream
[jemalloc issue](https://github.com/jemalloc/jemalloc/issues/1997),
which is mentioned to be caused due to a QEMU bug. It manifests as an error:
```
include/jemalloc/internal/rtree.h:118:3: error: constant expression evaluates to -12 which cannot be narrowed to type 'unsigned int' [-Wc++11-narrowing]
{RTREE_NSB, RTREE_NHIB + RTREE_NSB}
^~~~~~~~~
include/jemalloc/internal/rtree.h:22:19: note: expanded from macro 'RTREE_NSB'
#define RTREE_NSB (LG_VADDR - RTREE_NLIB)
^~~~~~~~~~~~~~~~~~~~~~~
```

</details>

## IDE Integration
Expand Down