Skip to content

cleanup: Simplify return type of saveReferenceImpl. #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
varungandhi-src merged 1 commit into from
Aug 5, 2022
Merged

cleanup: Simplify return type of saveReferenceImpl. #55

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions scip_indexer/SCIPIndexer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,9 +553,8 @@ class SCIPState {
return absl::OkStatus();
}

absl::Status saveReferenceImpl(const core::GlobalState &gs, core::FileRef file, const string &symbolString,
const vector<string> &overrideDocs, core::LocOffsets occLocOffsets,
int32_t symbol_roles) {
void saveReferenceImpl(const core::GlobalState &gs, core::FileRef file, const string &symbolString,
const vector<string> &overrideDocs, core::LocOffsets occLocOffsets, int32_t symbol_roles) {
ENFORCE(!symbolString.empty());
auto occLoc = trimColonColonPrefix(gs, core::Loc(file, occLocOffsets));
scip::Occurrence occurrence;
Expand All @@ -569,7 +568,6 @@ class SCIPState {
}
this->occurrenceMap[file].push_back(occurrence);
// TODO(varun): When should we fill out the diagnostics field?
return absl::OkStatus();
}

// Returns true if there was a cache hit.
Expand Down Expand Up @@ -657,7 +655,8 @@ class SCIPState {
ENFORCE(var.has_value(), "Failed to find source text for definition of local variable");
overrideDocs.push_back(fmt::format("```ruby\n{} = T.let(_, {})\n```", var.value(), overrideType->show(gs)));
}
return this->saveReferenceImpl(gs, file, occ.toString(gs, file), overrideDocs, occ.offsets, symbol_roles);
this->saveReferenceImpl(gs, file, occ.toString(gs, file), overrideDocs, occ.offsets, symbol_roles);
return absl::OkStatus();
}

absl::Status saveReference(const core::GlobalState &gs, core::FileRef file, NamedSymbolRef symRef,
Expand All @@ -681,8 +680,8 @@ class SCIPState {
overrideDocs = symRef.docStrings(gs, overrideType.value(), core::Loc(file, occLoc));
}
}

return this->saveReferenceImpl(gs, file, symbolString, overrideDocs, occLoc, symbol_roles);
this->saveReferenceImpl(gs, file, symbolString, overrideDocs, occLoc, symbol_roles);
return absl::OkStatus();
}

void saveDocument(const core::GlobalState &gs, const core::FileRef file) {
Expand Down