Missing field errors when indexing shopify-api-ruby gem

[varungandhi-src]

Input

https://github.com/Shopify/shopify-api-ruby 94591589ff57d8dcb3f37a97f70620766bb92ad6

Undesirable behavior

Seeing a bunch of errors:

lib/shopify_api/rest/resources/2023_01/order.rb:30: [scip-ruby] couldn't find field @company in class ::ShopifyAPI::Order;
    30 |      @company = T.let(nil, T.nilable(T::Hash[T.untyped, T.untyped]))
              ^^^^^^^^
  Note:
    are you using a code pattern like def MyClass.method which is unsupported by Sorbet?

lib/shopify_api/rest/resources/2023_01/order.rb:55: [scip-ruby] couldn't find field @merchant_of_record_app_id in class ::ShopifyAPI::Order;
    55 |      @merchant_of_record_app_id = T.let(nil, T.nilable(Integer))
              ^^^^^^^^^^^^^^^^^^^^^^^^^^
  Note:
    are you using a code pattern like def MyClass.method which is unsupported by Sorbet?

lib/shopify_api/rest/resources/2023_04/order.rb:30: [scip-ruby] couldn't find field @company in class ::ShopifyAPI::Order;
    30 |      @company = T.let(nil, T.nilable(T::Hash[T.untyped, T.untyped]))
              ^^^^^^^^
  Note:
    are you using a code pattern like def MyClass.method which is unsupported by Sorbet?

lib/shopify_api/rest/resources/2023_04/order.rb:35: [scip-ruby] couldn't find field @current_total_additional_fees_set in class ::ShopifyAPI::Order;
    35 |      @current_total_additional_fees_set = T.let(nil, T.nilable(T::Hash[T.untyped, T.untyped]))
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  Note:
    are you using a code pattern like def MyClass.method which is unsupported by Sorbet?

lib/shopify_api/rest/resources/2023_04/order.rb:56: [scip-ruby] couldn't find field @merchant_of_record_app_id in class ::ShopifyAPI::Order;
    56 |      @merchant_of_record_app_id = T.let(nil, T.nilable(Integer))
              ^^^^^^^^^^^^^^^^^^^^^^^^^^
  Note:
    are you using a code pattern like def MyClass.method which is unsupported by Sorbet?

lib/shopify_api/rest/resources/2023_04/order.rb:63: [scip-ruby] couldn't find field @original_total_additional_fees_set in class ::ShopifyAPI::Order;
    63 |      @original_total_additional_fees_set = T.let(nil, T.nilable(T::Hash[T.untyped, T.untyped]))
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  Note:
    are you using a code pattern like def MyClass.method which is unsupported by Sorbet?

lib/shopify_api/rest/resources/2022_10/order.rb:54: [scip-ruby] couldn't find field @merchant_of_record_app_id in class ::ShopifyAPI::Order;
    54 |      @merchant_of_record_app_id = T.let(nil, T.nilable(Integer))
              ^^^^^^^^^^^^^^^^^^^^^^^^^^
  Note:
    are you using a code pattern like def MyClass.method which is unsupported by Sorbet?

lib/shopify_api/rest/resources/2023_01/fulfillment_order.rb:21: [scip-ruby] couldn't find field @created_at in class ::ShopifyAPI::FulfillmentOrder;
    21 |      @created_at = T.let(nil, T.nilable(String))
              ^^^^^^^^^^^
  Note:
    are you using a code pattern like def MyClass.method which is unsupported by Sorbet?

lib/shopify_api/rest/resources/2023_01/fulfillment_order.rb:36: [scip-ruby] couldn't find field @updated_at in class ::ShopifyAPI::FulfillmentOrder;
    36 |      @updated_at = T.let(nil, T.nilable(T::Hash[T.untyped, T.untyped]))
              ^^^^^^^^^^^
  Note:
    are you using a code pattern like def MyClass.method which is unsupported by Sorbet?

lib/shopify_api/rest/resources/2023_04/fulfillment_order.rb:21: [scip-ruby] couldn't find field @created_at in class ::ShopifyAPI::FulfillmentOrder;
    21 |      @created_at = T.let(nil, T.nilable(String))
              ^^^^^^^^^^^
  Note:
    are you using a code pattern like def MyClass.method which is unsupported by Sorbet?

lib/shopify_api/rest/resources/2023_04/fulfillment_order.rb:36: [scip-ruby] couldn't find field @updated_at in class ::ShopifyAPI::FulfillmentOrder;
    36 |      @updated_at = T.let(nil, T.nilable(T::Hash[T.untyped, T.untyped]))
              ^^^^^^^^^^^
  Note:
    are you using a code pattern like def MyClass.method which is unsupported by Sorbet?

lib/shopify_api/rest/resources/2023_04/transaction.rb:42: [scip-ruby] couldn't find field @total_unsettled_set in class ::ShopifyAPI::Transaction;
    42 |      @total_unsettled_set = T.let(nil, T.nilable(T::Hash[T.untyped, T.untyped]))
              ^^^^^^^^^^^^^^^^^^^^
  Note:
    are you using a code pattern like def MyClass.method which is unsupported by Sorbet?
Errors: 12

With scip-ruby v0.3.2, there were fewer errors.

lib/shopify_api/rest/resources/2023_04/transaction.rb:42: [scip-ruby] couldn't find field @total_unsettled_set in class ::ShopifyAPI::Transaction;
    42 |      @total_unsettled_set = T.let(nil, T.nilable(T::Hash[T.untyped, T.untyped]))
              ^^^^^^^^^^^^^^^^^^^^
  Note:
    are you using a code pattern like def MyClass.method which is unsupported by Sorbet?

lib/shopify_api/rest/resources/2022_04/fulfillment_service.rb:21: [scip-ruby] couldn't find field @format in class ::ShopifyAPI::FulfillmentService;
    21 |      @format = T.let(nil, T.nilable(String))
              ^^^^^^^
  Note:
    are you using a code pattern like def MyClass.method which is unsupported by Sorbet?
Errors: 2

Expected behavior

There shouldn't be any errors.

scip-ruby-debug indexing output

n/a

Configuration

ruby 2.7.2p137 (2020-10-01 revision 5445e04352) [arm64-darwin21]
Bundler version 2.3.26
  * sorbet (0.5.10438)
        Summary: A Typechecker for Ruby
        Homepage: https://sorbet.org
        Source Code: https://github.com/sorbet/sorbet
        Path: /Users/varun/.asdf/installs/ruby/2.7.2/lib/ruby/gems/2.7.0/gems/sorbet-0.5.10438
        Reverse Dependencies:
                shopify_api (13.0.0) depends on sorbet (>= 0)
                sorbet-static-and-runtime (0.5.10438) depends on sorbet (= 0.5.10438)
                spoom (1.1.11) depends on sorbet (>= 0.5.9204)

scip-ruby built locally

Additional info

No response

[varungandhi-src]

Hmm, the number of errors returned is non-deterministic. I just tried with HEAD, and am seeing a varying number of errors. I thought we only performed lookups based on state initialized during merging, not later on. 😕

[varungandhi-src]

Fixed in #186