Context
The Account model currently stores only the provider type (e.g., github or gitlab) without identifying which specific connection instance the account belongs to.
Problem
When config.connections contains multiple connections of the same type (e.g., GitHub Cloud and a self-hosted GitHub Enterprise instance), the permission syncer uses .find(connection => connection.type === 'github')?.url which always returns the first match—regardless of which instance the account actually belongs to.
Impact
- Permission syncs may call the wrong API endpoint
- Failed syncs for users with accounts on different instances
- Potential for incorrect permission data or data corruption
Solution
Add a mechanism to uniquely identify connections and link accounts to their specific connection instance (e.g., connectionId field on the Account model).
References
This affects both GitHub and GitLab permission syncing in accountPermissionSyncer.ts.
Context
The
Accountmodel currently stores only the provider type (e.g.,githuborgitlab) without identifying which specific connection instance the account belongs to.Problem
When
config.connectionscontains multiple connections of the same type (e.g., GitHub Cloud and a self-hosted GitHub Enterprise instance), the permission syncer uses.find(connection => connection.type === 'github')?.urlwhich always returns the first match—regardless of which instance the account actually belongs to.Impact
Solution
Add a mechanism to uniquely identify connections and link accounts to their specific connection instance (e.g.,
connectionIdfield on theAccountmodel).References
This affects both GitHub and GitLab permission syncing in
accountPermissionSyncer.ts.