Repository navigation
feat: ✨ add centered property to sd-tab-group - #3400
MartaPintoTeixeira wants to merge 4 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 4b7a39a The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
🚀 Storybook has been deployed for branch |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Thanks for picking this up! I compared it with the updated Figma branch (#2340) and tested it in the branch Storybook. centered works for default and container, the separation line extends on both sides, the indicator repositions correctly, and overflowing tabs still scroll without being clipped. The name centered also fits our boolean naming (inverted, stacked, rounded…), so no change needed there. Please update to match the Figma review:
Tests and CI:
Once this is merged, I'll remove the "Figma-only for now" note from the Centered section in the Figma docs. |
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Description:
Adds a
centeredproperty tosd-tab-group(Figma sd-tab-group V.2.2.3). Tabs are centered within the tab group and the separation line extends on both sides. Works for thedefaultandcontainervariants.centeredboolean property (reflected); the active indicator repositions correctly when centered.Centeredstory on the sd-tab-group docs page.centeredinstead of the::part(tabs)CSS workaround.sd-tab V.2.2.2 (removed unused gap on the active indicator) has no visual change, so nothing changes in code.
Definition of Reviewable:
Closes #2907
🤖 Generated with Claude Code