Skip to content

feat: ✨ add centered property to sd-tab-group - #3400

Draft
MartaPintoTeixeira wants to merge 4 commits into
mainfrom
feat/tab-group-centered
Draft

MartaPintoTeixeira wants to merge 4 commits into
mainfrom
feat/tab-group-centered

Conversation

@MartaPintoTeixeira

Copy link
Copy Markdown
Contributor

Description:

Adds a centered property to sd-tab-group (Figma sd-tab-group V.2.2.3). Tabs are centered within the tab group and the separation line extends on both sides. Works for the default and container variants.

  • New centered boolean property (reflected); the active indicator repositions correctly when centered.
  • New Centered story on the sd-tab-group docs page.
  • "Tab Group Center Aligned" template now uses centered instead of the ::part(tabs) CSS workaround.

sd-tab V.2.2.2 (removed unused gap on the active indicator) has no visual change, so nothing changes in code.

Definition of Reviewable:

  • Documentation is created/updated
  • E2E tests (features, a11y, bug fixes) are created/updated
  • Stories (features, a11y) are created/updated
  • relevant tickets are linked

Closes #2907

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@changeset-bot

changeset-bot Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 4b7a39a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@solid-design-system/components Minor
@solid-design-system/docs Minor
@solid-design-system/mcp Minor
@solid-design-system/styles Minor
@solid-design-system/tokens Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Storybook has been deployed for branch feat_tab-group-centered

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coraliefeil

Copy link
Copy Markdown
Contributor

Thanks for picking this up! I compared it with the updated Figma branch (#2340) and tested it in the branch Storybook. centered works for default and container, the separation line extends on both sides, the indicator repositions correctly, and overflowing tabs still scroll without being clipped. The name centered also fits our boolean naming (inverted, stacked, rounded…), so no change needed there.

Please update to match the Figma review:

Tests and CI:

  • Screenshot test: "Sample: Centered" in tab-group.test.stories.ts still uses the ::part(tabs) { justify-content: center } workaround. Please switch it to so Chromatic covers the new property.
  • Unit test: please add a test for centered in tab-group.test.ts (attribute reflected, tabs centered).
  • MCP metadata: run pnpm build in packages/mcp and commit the regenerated metadata (new Centered story, updated template). Otherwise check:metadata will probably fail once the PR leaves draft.

Once this is merged, I'll remove the "Figma-only for now" note from the Centered section in the Figma docs.

@coraliefeil coraliefeil moved this from 📋 Backlog to 👀 In review in Solid Design System Project Board Oct 14, 2026
@MartaPintoTeixeira MartaPintoTeixeira self-assigned this Oct 15, 2026
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

This branch was successfully deployed

1 active deployment
github-pages — 4b7a39ad Deployed Oct 15, 2026 by MartaPintoTeixeira via deploy #5621
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 👀 In review

Development

Successfully merging this pull request may close these issues.

feat[design]: ✨ sd-tab-group centered property

2 participants