Repository navigation
feat: add Figma icons export pipeline and workflows - #3396
Merged
Merged
Conversation
- Introduced new scripts for fetching and optimizing icons from Figma. - Added configuration for Figma asset exports, including theme and category mappings. - Implemented workflows for downloading CELUM icons and updating bundled icons. - Created tests for the new icon fetching and exporting functionality. - Updated pnpm-lock.yaml with new dependencies for Figma export assets. - Added .env.example for Figma token configuration. - Created a changeset for the updated bundled component and status icons.
🦋 Changeset detectedLatest commit: cfaec05 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
🚀 Storybook has been deployed for branch |
Status icon sm frames in Figma were 12.057px wide, which exported as viewBox 0 0 13 12 and shrank the glyphs. Frames are now 12x12. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…g synchronization
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Adds a Figma-based icons export pipeline to keep bundled component/status icons and theme-specific CELUM icons aligned with the Theming Icon Asset Library.
figma-export-assetsand SVGO, using explicit Figma-to-code mappings, an internal icons allowlist, and reproducible output.Validation
pnpm --filter @solid-design-system/components test:figma(4 tests).pnpm verify, icon browser tests, and authenticated Figma workflow runs were not run during PR preparation. Review bundled icons in light/dark themes and component contexts.Setup
Configure the
FIGMA_TOKENActions secret and allow Actions to create pull requests. Bot-created update PRs may require checks to be triggered separately.Definition of Reviewable: