Skip to content

fix: sd-dropdown, sd-dialog and sd-drawer staying invisible when reopened during its hide animation #3402

Closed as not planned

Description

@auroraVasconcelos

Follow up ticket for #3384.

Reopening sd-tooltip while its hide animation was still running (~150 ms) left it open but
invisible: open === true, but body.hidden === true and popup.active === false.
Reachable by clicking the trigger three times quickly, or tabbing onto it, away and back.

  • A show/hide that is superseded by a newer one now stops instead of finishing its work.
    stopAnimations() targets the element that is actually animated (popup.popup).
  • A superseded show/hide no longer emits sd-after-show / sd-after-hide, so these events
    always match the final state. show() / hide() still resolve, once the latest
    transition has ended.
    Not part of this PR: sd-dropdown, sd-dialog and sd-drawer show the same defect.
  • Fix sd-dropdown
  • Fix sd-dialog
  • Fix sd-drawer

Technical Information

DoR

  • Item has business value
  • Item has been estimated by the team
  • Item is clear and well-defined
  • Item dependencies have been identified
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions