Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
solev
force-pushed
the
refactor/rename-capabilities-to-integrations
branch
from
August 22, 2026 12:22
b3a0e77 to
6874ac8
Compare
solev
force-pushed
the
refactor/rename-capabilities-to-integrations
branch
from
August 22, 2026 12:32
6874ac8 to
bf01484
Compare
`capabilities/` had no precedent in any repo checked for "folder of optional third-party integrations", and the word is heavily overloaded: Linux CAP_*, WASI, Kubernetes securityContext, Playwright config, and capability-based security. Worse, the nearest in-domain neighbours use it for the opposite idea — dubinc/dub has plan-capabilities.ts for billing entitlements, and Formbricks has modules/entitlements/. `integrations/` is what the ecosystem actually calls this, verified against live directory listings: withastro/astro packages/integrations (react, mdx, netlify), dubinc/dub apps/web/lib/integrations (stripe, slack, shopify), better-auth packages/better-auth/src/integrations. It also matches Rocket's own test in docs/agents/upstreaming.md: "does it require external configuration or a third-party account?" That is the definition of an integration. CONTEXT.md previously listed "integration" under Avoid for this term. That was a record of the decision now being reviewed, so it could not be used to defend itself. The glossary also never stated the trait the whole contract rests on: optionality. Absence being valid is the entire point, yet it was only implied by contrast with Core. The definition now names it outright. Two disambiguations fall out of the rename: - the guide section "## Integration" (how a thing is wired in) becomes "## Wiring", so an integration guide no longer has an Integration section - the tests are named for what they assert rather than their subject, avoiding a clash with tests/integration/ as a methodology: capability-contract -> availability-contract, and capability-endpoints -> webhook-endpoints Research and the argument against are in docs/research/folder-naming-prior-art.md. Verified: bun run check exits 0, 27/27 integration tests, 7/7 Playwright with no retries. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
solev
force-pushed
the
refactor/rename-capabilities-to-integrations
branch
from
August 22, 2026 12:37
bf01484 to
55b4544
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #13. Answers "I am not sure I like the capabilities folder naming."
What the research found
Full write-up in
docs/research/folder-naming-prior-art.md. Every path was verified against the live GitHub contents API, not a blog post.capabilities/had no precedent in any repo checked for this meaning. And the word is heavily overloaded — LinuxCAP_*, WASI, KubernetessecurityContext, Playwright config, capability-based security.The damaging part: the nearest in-domain neighbours use it for the opposite idea.
dubinc/dubapps/web/lib/plan-capabilities.tsformbricks/formbricksapps/web/modules/entitlements/integrations/is what the ecosystem calls this, verified:withastro/astropackages/integrations/react,mdx,netlify,cloudflare,partytowndubinc/dubapps/web/lib/integrations/stripe,slack,shopify,hubspot,segmentbetter-auth/better-authpackages/better-auth/src/integrations/next-js,svelte-kit,nodeIt also matches Rocket's own test in
docs/agents/upstreaming.md: "Does it require external configuration or a third-party account?" That is the definition of an integration.Two arguments I had to discard
CONTEXT.mdlisted "integration" under Avoid. That is a record of the decision under review, so citing it is circular.tests/integration/(methodology) andapp/integrations/(subject). Real, but it touches two files, and both read better named for what they assert.Closest analogue, and why it lost
medusajs/medusa→packages/modules/providers/(payment-stripe,notification-sendgrid,file-s3) is the nearest match in shape. But a Medusa provider implements a swappable interface, whereas Rocket's billing is the billing concern, Polar-shaped throughout. Soproviders/would misdescribe it.Worth noting: Medusa's
notification-local/file-localno-op fallbacks are exactly whatapp/lib/email/delivery.server.tsdoes — a nice independent validation of that seam design.Changes
app/integrations/app/capabilities/docs/integrations/docs/capabilities/app/lib/integration.tsapp/lib/capability.tsIntegrationUnavailableErrorCapabilityUnavailableErrorrequireIntegration()requireCapability()IntegrationGroupCapabilityGroupBILLING_INTEGRATION/AI_CHAT_INTEGRATION*_CAPABILITYTwo disambiguations fall out of it:
## Integration(how a thing is wired in) becomes## Wiring, so an integration guide no longer contains an Integration section.capability-contract→availability-contract,capability-endpoints→webhook-endpoints.Glossary gap closed
CONTEXT.mddefined the term without ever mentioning optionality — the trait the entire contract rests on. Absence being valid is the whole point, yet it was implied only by contrast with Core. The definition now names it outright.The honest argument against
"Integration" describes where the code points (outward, at a vendor); "capability" describes what the application gains. If Rocket ever ships an optional concern with no vendor behind it — in-house audit logging, a pg-boss job runner — it would be an integration with nothing.
Every item present and on the backlog is vendor-backed today, so this is a bet that the optional surface stays that way. Easy to revisit, but worth saying out loud.
Verification
bun run checkexits 0 (format, lint, typecheck, env check, unit + DOM, integration, drift, build)capabilityreferences outside.agents/skills/(vendored, generic usage)Scope note: this branch now contains only the rename. The signup-atomicity fix
that was briefly stacked here was moved to #13, where the hook it fixes is
introduced, so a real bug fix does not depend on accepting a naming change.